Bug 46408 – Add C API to WebKit2 for changing the font families

• Component: WebKit2
• Status: RESOLVED FIXED

[Kenneth Rohde Christiansen]

Created attachment 68595 [details]
Patch

Patch coming...

[Sam Weinig]

Comment on attachment 68595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68595&action=review

> WebKit2/UIProcess/API/C/WKPreferences.cpp:160
> +void WKPreferencesSetStandardFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setStandardFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WebPreferencesGetStandardFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->standardFontFamily());
> +}
> +
> +void WKPreferencesSetFixedFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setFixedFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetFixedFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->fixedFontFamily());
> +}
> +
> +void WKPreferencesSetSerifFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setSerifFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetSerifFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->serifFontFamily());
> +}
> +
> +void WKPreferencesSetSansSerifFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setSansSerifFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetSansSerifFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->sansSerifFontFamily());
> +}
> +
> +void WKPreferencesSetCursiveFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setCursiveFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetCursiveFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->cursiveFontFamily());
> +}
> +
> +void WKPreferencesSetFantasyFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setFantasyFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetFantasyFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->fantasyFontFamily());
> +}

Since all the getters here return copied strings, these need to have the word copy in them instead of get.

[Kenneth Rohde Christiansen]

> > +WKStringRef WKPreferencesGetFantasyFontFamily(WKPreferencesRef preferencesRef)
> > +{
> > +    return toCopiedRef(toWK(preferencesRef)->fantasyFontFamily());
> > +}
> 
> Since all the getters here return copied strings, these need to have the word copy in them instead of get.

Should they be called Copy instead of Get? I see that elsewhere in WebKit2.

Like: WKPreferencesCopyFantasyFontFamily ?

[Kenneth Rohde Christiansen]

(In reply to comment #2)
> > > +WKStringRef WKPreferencesGetFantasyFontFamily(WKPreferencesRef preferencesRef)
> > > +{
> > > +    return toCopiedRef(toWK(preferencesRef)->fantasyFontFamily());
> > > +}
> > 
> > Since all the getters here return copied strings, these need to have the word copy in them instead of get.
> 
> Should they be called Copy instead of Get? I see that elsewhere in WebKit2.
> 
> Like: WKPreferencesCopyFantasyFontFamily ?

I should have read your comment better :-) still waking up.

[Kenneth Rohde Christiansen]

Created attachment 68676 [details]
Patch 2

Change Get to Copy.

[Kenneth Rohde Christiansen]

Landed in 68258