Bug 46325

Summary:

Rename FileWriterClient to AsyncFileWriterClient.

Product:

WebKit

Reporter:

Eric U. <ericu>

Component:

DOM

Assignee:

Eric U. <ericu>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, dumi, kinuko

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

44358

Attachments:

Description	Flags
Patch	none

Description Eric U. 2010-09-22 17:50:14 PDT

As promised in https://bugs.webkit.org/show_bug.cgi?id=44361, I'll now rename FileWriterClient to AsyncFileWriterClient, which is more accurate, because it's the client of the AsyncFileWriter.

Comment 1 Eric U. 2010-09-22 20:33:49 PDT

Created attachment 68494 [details]
Patch

Comment 2 Kinuko Yasuda 2010-09-22 20:52:11 PDT

Comment on attachment 68494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68494&action=review

Thanks for changing this!  Lgtm (except that the duplicated WebCore/fileapi/AsyncFileWriterClient.h)

> WebCore/fileapi/AsyncFileWriterClient.h:1
> +/*

Hmm I wonder how we got this duplicated file entry in this patch (we have correct version of WebCore/fileapi/AsyncFileWriterClient.h diff below...)

Comment 3 Eric U. 2010-09-23 08:41:33 PDT

(In reply to comment #2)
> (From update of attachment 68494 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68494&action=review
> 
> Thanks for changing this!  Lgtm (except that the duplicated WebCore/fileapi/AsyncFileWriterClient.h)
> 
> > WebCore/fileapi/AsyncFileWriterClient.h:1
> > +/*
> 
> Hmm I wonder how we got this duplicated file entry in this patch (we have correct version of WebCore/fileapi/AsyncFileWriterClient.h diff below...)

Yeah, I'm not sure what's up with that.  Perhaps that's how it shows an "svn mv" followed by editing?  The patch came out of webkit-patch; I didn't create it manually.  I can try svn-create-patch instead and see if it's any different when I get in to the office.

Comment 4 Eric U. 2010-09-23 10:33:09 PDT

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 68494 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=68494&action=review
> > 
> > Thanks for changing this!  Lgtm (except that the duplicated WebCore/fileapi/AsyncFileWriterClient.h)
> > 
> > > WebCore/fileapi/AsyncFileWriterClient.h:1
> > > +/*
> > 
> > Hmm I wonder how we got this duplicated file entry in this patch (we have correct version of WebCore/fileapi/AsyncFileWriterClient.h diff below...)
> 
> Yeah, I'm not sure what's up with that.  Perhaps that's how it shows an "svn mv" followed by editing?  The patch came out of webkit-patch; I didn't create it manually.  I can try svn-create-patch instead and see if it's any different when I get in to the office.

I get the same patch from svn-create-patch; I think it's just trying to show a mv followed by an edit, so I'm guessing it's OK.

Comment 5 WebKit Commit Bot 2010-09-23 12:33:56 PDT

Comment on attachment 68494 [details]
Patch

Clearing flags on attachment: 68494

Committed r68180: <http://trac.webkit.org/changeset/68180>

Comment 6 WebKit Commit Bot 2010-09-23 12:34:01 PDT

All reviewed patches have been landed.  Closing bug.