Summary: | REGRESSION: Lots of fast canvas updates fail to completely render | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joel Martin <webkit> | ||||||||
Component: | Canvas | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | antoine.mercadal, ap, chris, commit-queue, mdelaney7, mitz, scheib, simon.fraser, suresh.voruganti | ||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
URL: | http://kanaka.github.com/noVNC/webkit_canvas_bug.html | ||||||||||
Attachments: |
|
Description
Joel Martin
2010-09-22 16:32:14 PDT
Created attachment 68471 [details]
Picture of canvas failure to render
Here is a picture of the state where the canvas commands have completed, but the canvas is not showing all the data (i.e. the image should continue well past the bottom of the window.
I confirm. Confirmed with a local debug build of r68167 on Mac OS X. I believe this was caused by this change: https://bugs.webkit.org/show_bug.cgi?id=44741 http://trac.webkit.org/changeset/66295 CC-ing Vincent. I have it reproduced, and will investigate. This was caused by http://trac.webkit.org/changeset/66295, logic error in CanvasRenderingContext2D::putImageData (sourceRect incorrect). I have a fix in hand and am looking for tests that should have caught this or will write one. Created attachment 69133 [details]
Patch
Comment on attachment 69133 [details] Patch Rejecting patch 69133 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: ccessful. Files=14, Tests=304, 1 wallclock secs ( 0.65 cusr + 0.14 csys = 0.79 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/abarth/git/webkit-queue/LayoutTests Testing 21409 test cases. fast/repaint/canvas-putImageData.html -> failed Exiting early after 1 failures. 15031 tests run. 201.57s total testing time 15030 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4157029 Created attachment 69415 [details]
Patch
Comment on attachment 69415 [details]
Patch
Previous commit queue failed - caught an error with the test. The expected results had carriage returns in them.
Comment on attachment 69415 [details] Patch Clearing flags on attachment: 69415 Committed r68868: <http://trac.webkit.org/changeset/68868> All reviewed patches have been landed. Closing bug. Awesome! I pulled the nightly and tested with noVNC. Looks good. Thanks. Top list error for Services, so please cherry pick the fix for Qtwebkit 2.1 |