Bug 46314

Summary:

The RenderView's block-flow should match the root element's block-flow.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

46123

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Dave Hyatt 2010-09-22 15:18:28 PDT

Make sure the RenderView uses the block-flow of the root when laying out the root.  This isn't in the spec, but it just seems patently obvious to me that it should work this way.  Otherwise there's no way to control the overall direction of the document, since the <html> wouldn't lay out right.

Comment 1 Dave Hyatt 2010-09-22 15:24:37 PDT

Created attachment 68453 [details]
Patch

Comment 2 Simon Fraser (smfr) 2010-09-22 15:51:01 PDT

Comment on attachment 68453 [details]
Patch

Got tests?

Comment 3 Dave Hyatt 2010-09-22 21:22:27 PDT

(In reply to comment #2)
> (From update of attachment 68453 [details])
> Got tests?

It's untestable.  You can't see the RenderView's style, and we don't yet do anything layout-wise with block-flow.  Once we do it will be testable.

Comment 4 Simon Fraser (smfr) 2010-09-23 08:11:40 PDT

Comment on attachment 68453 [details]
Patch

Explain lack of tests in the changelog.

Comment 5 Dave Hyatt 2010-09-23 10:18:21 PDT

Fixed in r68157.