Bug 46305

Summary: Stub out a PluginProcessManager class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Anders Carlsson
Reported 2010-09-22 13:58:11 PDT
Stub out a PluginProcessManager class
Attachments
Patch (10.63 KB, patch)
2010-09-22 13:59 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-09-22 13:59:31 PDT
Created attachment 68435 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-09-22 14:03:56 PDT
Comment on attachment 68435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68435&action=review What about WebKit2.vcproj? > WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:56 > +void PluginProcessManager::removePluginProcessProxy(PluginProcessProxy* pluginProcessProxy) > +{ > + size_t vectorIndex = m_pluginProcesses.find(pluginProcessProxy); > + ASSERT(vectorIndex != notFound); > + > + m_pluginProcesses.remove(vectorIndex); > +} Maybe a HashSet would be better? > WebKit2/UIProcess/WebProcessProxy.h:97 > + WebContext* context() const { return m_context; } I don't see any callers of this function. It seems strange to add it in this patch if it won't be used until a future patch.
Anders Carlsson
Comment 3 2010-09-22 15:08:51 PDT
Committed r68088: <http://trac.webkit.org/changeset/68088>
Note You need to log in before you can comment on or make changes to this bug.