Bug 46298 – Add logicalWidth/Height getters and setters to RenderBox

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

Add logicalWidth/Height getters and setters to RenderBox.

[Dave Hyatt]

Created attachment 68428 [details]
Patch

Comment on attachment 68428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68428&action=review

> WebCore/rendering/RenderBox.cpp:90
> +    if (style()->isVerticalBlockFlow())
> +        return width();
> +    return height();

Maybe now it’s too late to say this, but how about
return style()->isVerticalBlockFlow() ? width() : height();
instead?

[Dave Hyatt]

(In reply to comment #2)
> (From update of attachment 68428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68428&action=review
> 
> > WebCore/rendering/RenderBox.cpp:90
> > +    if (style()->isVerticalBlockFlow())
> > +        return width();
> > +    return height();
> 
> Maybe now it’s too late to say this, but how about
> return style()->isVerticalBlockFlow() ? width() : height();
> instead?

Not too late. :)

[Dave Hyatt]

Fixed in r68077.