Summary: | Web Inspector: CRASH at node highlight on MAC Safari | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2010-09-22 07:03:35 PDT
Created attachment 68663 [details]
[patch] initial version.
Comment on attachment 68663 [details] [patch] initial version. View in context: https://bugs.webkit.org/attachment.cgi?id=68663&action=review > WebKit/mac/WebInspector/WebNodeHighlightView.mm:77 > + [NSGraphicsContext restoreGraphicsState]; Should restore unconditionally. Created attachment 68666 [details]
[patch] initial version.
Comment on attachment 68666 [details] [patch] initial version. Clearing flags on attachment: 68666 Committed r68247: <http://trac.webkit.org/changeset/68247> All reviewed patches have been landed. Closing bug. Comment on attachment 68666 [details] [patch] initial version. View in context: https://bugs.webkit.org/attachment.cgi?id=68666&action=review I know this landed. Here are some things to think about to improve later patches. > WebKit/mac/ChangeLog:14 > + Web Inspector: CRASH at node highlight on MAC Safari. > + 1) run-safari --debug > + 2) open inspector > + 3) open elements panel > + 4) hover mouse over elements panel items multiple times > + 5) CRASH > + Looks like it is a race condition. WebNodeHighlightView doesn't check > + the pointer to WebNodeHighligh object and it can be nil. > + > + https://bugs.webkit.org/show_bug.cgi?id=46261 This still isn't the usual ChangeLog style, but I guess everyones does it differently so I'll stop bringing it up. Just noticed there was a typo, "WebNodeHighligh". > WebKit/mac/WebInspector/WebNodeHighlightView.mm:71 > + if (_webNodeHighlight) { > + [NSGraphicsContext saveGraphicsState]; I think an early return would have made this easier to read, and is a common style. |