Bug 46204

Summary: REGRESSION: ~1.4% sunspider regression in interpreter due to 54724 and 54596
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch oliver: review+

Geoffrey Garen
Reported 2010-09-21 11:32:38 PDT
REGRESSION: ~1.4% sunspider regression in interpreter due to 54724 and 54596
Attachments
Patch (1.53 KB, patch)
2010-09-21 11:36 PDT, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2010-09-21 11:36:05 PDT
Created attachment 68266 [details] Patch
WebKit Review Bot
Comment 2 2010-09-21 11:40:22 PDT
Attachment 68266 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/PassRefPtr.h:51: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] JavaScriptCore/wtf/PassRefPtr.h:57: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2010-09-21 11:43:26 PDT
Committed r67972: <http://trac.webkit.org/changeset/67972>
Note You need to log in before you can comment on or make changes to this bug.