Bug 46182

Summary:

[Qt] On Maemo platform, web style is missing for some inputs

Product:

WebKit

Reporter:

Ragner Magalhaes <ragner.magalhaes>

Component:

WebKit Qt

Assignee:

Ragner Magalhaes <ragner.magalhaes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, diegohcg, kenneth, luiz, tonikitoo

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Adjust missing style to behaves like a regular text field.	none
Style before the patch	none
After the patch	none
No new tests. (OOPS!) line removed	none

Ragner Magalhaes

Reported 2010-09-21 06:22:47 PDT

Maemo web style is missing for email, color, search, date, number and url inputs.

Attachments
Adjust missing style to behaves like a regular text field. (2.24 KB, patch) 2010-09-21 06:34 PDT, Ragner Magalhaes	no flags	Details Formatted Diff Diff
Style before the patch (24.63 KB, image/png) 2010-09-21 06:36 PDT, Ragner Magalhaes	no flags	Details
After the patch (22.07 KB, image/png) 2010-09-21 06:37 PDT, Ragner Magalhaes	no flags	Details
No new tests. (OOPS!) line removed (2.22 KB, patch) 2010-09-21 07:04 PDT, Ragner Magalhaes	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ragner Magalhaes

Comment 1 2010-09-21 06:34:58 PDT

Created attachment 68230 [details] Adjust missing style to behaves like a regular text field.

Ragner Magalhaes

Comment 2 2010-09-21 06:36:48 PDT

Created attachment 68231 [details] Style before the patch

Ragner Magalhaes

Comment 3 2010-09-21 06:37:39 PDT

Created attachment 68232 [details] After the patch

Andreas Kling

Comment 4 2010-09-21 06:43:50 PDT

Comment on attachment 68230 [details] Adjust missing style to behaves like a regular text field. View in context: https://bugs.webkit.org/attachment.cgi?id=68230&action=review > WebCore/ChangeLog:8 > + No new tests. (OOPS!) This line should be removed. r=me

Ragner Magalhaes

Comment 5 2010-09-21 07:04:31 PDT

Created attachment 68236 [details] No new tests. (OOPS!) line removed

WebKit Commit Bot

Comment 6 2010-09-21 08:15:10 PDT

Comment on attachment 68236 [details] No new tests. (OOPS!) line removed Rejecting patch 68236 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/abarth/git/webkit-queue/LayoutTests Testing 21325 test cases. websocket/tests/null-character.html -> failed Exiting early after 1 failures. 21301 tests run. 562.03s total testing time 21300 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4039090

WebKit Commit Bot

Comment 7 2010-09-21 08:51:25 PDT

Comment on attachment 68236 [details] No new tests. (OOPS!) line removed Rejecting patch 68236 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/css/themeQtMaemo5.css A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://queues.webkit.org/results/4068086

Diego Gonzalez

Comment 8 2010-09-22 05:23:10 PDT

Comment on attachment 68236 [details] No new tests. (OOPS!) line removed Clearing flags. Patch landed manually at r68035

Note You need to log in before you can comment on or make changes to this bug.