Bug 46179

Summary: [gtk] Move copyContextProperties outside the GraphicsContextCairo
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch mrobinson: review+

Alejandro G. Castro
Reported 2010-09-21 05:18:31 PDT
We need to use this function in the contextshadow in order to add the tiled functions (bug 45902).
Attachments
Patch (4.02 KB, patch)
2010-09-21 05:34 PDT, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (8.71 KB, patch)
2010-09-21 12:43 PDT, Alejandro G. Castro 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2010-09-21 05:34:02 PDT
Created attachment 68223 [details] Patch
Martin Robinson
Comment 2 2010-09-21 08:51:29 PDT
Comment on attachment 68223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68223&action=review > WebCore/platform/graphics/gtk/CairoUtilities.cpp:32 > +#include <wtf/Vector.h> > + > #include <cairo.h> > #include <gtk/gtk.h> <wtf/Vector.h> should go under <gtk/gtk.h> per WebKit code style. r=me with this change. We'll have to wait to land this until after the original ContextShadow patch lands. :/
Martin Robinson
Comment 3 2010-09-21 08:57:02 PDT
Comment on attachment 68223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68223&action=review >> WebCore/platform/graphics/gtk/CairoUtilities.cpp:32 >> #include <gtk/gtk.h> > > <wtf/Vector.h> should go under <gtk/gtk.h> per WebKit code style. > > r=me with this change. We'll have to wait to land this until after the original ContextShadow patch lands. :/ This will need to go into a platform-independent file. :/
Alejandro G. Castro
Comment 4 2010-09-21 12:43:35 PDT
Created attachment 68276 [details] Patch
Martin Robinson
Comment 5 2010-09-21 12:47:09 PDT
Comment on attachment 68276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68276&action=review Looks good! Please fix these small nits before landing: > WebCore/GNUmakefile.am:3357 > + WebCore/platform/graphics/cairo/CairoUtilities.cpp \ > + WebCore/platform/graphics/cairo/CairoUtilities.h \ These should be moved under CairoPath.h to keep the source list in alphabetical order. > WebCore/GNUmakefile.am:3392 > + WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp \ > + WebCore/platform/graphics/gtk/GdkCairoUtilities.h \ These should be moved under FontGtk.cpp to keep the source list in alphabetical order. > WebCore/platform/graphics/cairo/CairoUtilities.cpp:31 > +#include <cairo.h> > + > +#include <wtf/Vector.h> Remove the empty line here.
Alejandro G. Castro
Comment 6 2010-09-21 13:24:13 PDT
Patch landed http://trac.webkit.org/changeset/67981
Note You need to log in before you can comment on or make changes to this bug.