Bug 46176

Summary: [GTK] Bump minimum requirement for libsoup to 2.30
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Xan Lopez <xan.lopez>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 47889    
Bug Blocks:    
Attachments:
Description Flags
soup230.diff none

Xan Lopez
Reported 2010-09-21 04:46:51 PDT
2.30 is pretty old by now, no reason to not test all our codepaths always.
Attachments
soup230.diff (8.66 KB, patch)
2010-09-21 04:49 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-09-21 04:49:03 PDT
Created attachment 68219 [details] soup230.diff
WebKit Review Bot
Comment 2 2010-09-21 06:27:00 PDT
Attachment 68219 [details] did not build on gtk: Build output: http://queues.webkit.org/results/4101011
Martin Robinson
Comment 3 2010-09-21 08:43:00 PDT
Comment on attachment 68219 [details] soup230.diff View in context: https://bugs.webkit.org/attachment.cgi?id=68219&action=review > ChangeLog:9 > + Bump minimum libsoup to required version to 2.30.0. > + I think we should list the features which require this version here.
Martin Robinson
Comment 4 2010-09-21 10:29:30 PDT
Comment on attachment 68219 [details] soup230.diff Looks good with the ChangeLog expansion.
Martin Robinson
Comment 5 2010-10-12 17:14:46 PDT
Can't recall the status of this issue. Are we waiting on the bot upgrade?
Eric Seidel (no email)
Comment 6 2010-10-13 12:27:33 PDT
Attachment 68219 [details] was posted by a committer and has review+, assigning to Xan Lopez for commit.
Xan Lopez
Comment 7 2010-10-19 00:51:11 PDT
Comment on attachment 68219 [details] soup230.diff Pushed as r70034.
Xan Lopez
Comment 8 2010-10-19 00:51:22 PDT
Closing.
WebKit Review Bot
Comment 9 2010-10-19 01:44:36 PDT
http://trac.webkit.org/changeset/70034 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/media/video-cookie.html http/tests/media/video-referer.html
Note You need to log in before you can comment on or make changes to this bug.