Bug 46148

Summary: Zombie WebProcesses are left around
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: WebKit2Assignee: Anders Carlsson <andersca>
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Patch mitz: review+

Description Anders Carlsson 2010-09-20 17:46:42 PDT
Zombie WebProcesses are left around
Comment 1 Anders Carlsson 2010-09-20 17:50:55 PDT
Created attachment 68167 [details]
Comment 2 Anders Carlsson 2010-09-20 17:51:17 PDT
Comment 3 WebKit Review Bot 2010-09-20 17:57:23 PDT
Attachment 68167 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/mac/MainMac.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 mitz 2010-09-20 17:58:59 PDT
Comment on attachment 68167 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=68167&action=review

> WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:76
> +static void setupTerminationNotificationHandler(pid_t pid)

typo: setup
Comment 5 Anders Carlsson 2010-09-21 08:39:48 PDT
Committed r67954: <http://trac.webkit.org/changeset/67954>