Bug 46125

Summary:

Convert table cell intrinsic padding to be logical instead of hardcoded.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

46123

Attachments:

Description	Flags
Patch	mitz: review+

Dave Hyatt

Reported 2010-09-20 14:53:22 PDT

Table cell intrinsic padding needs to be converted to be logical instead of physical. This is complicated, since the intrinsic padding isn't based off the cell's block-flow/direction but off the table row's.

Attachments
Patch (11.04 KB, patch) 2010-09-21 00:26 PDT, Dave Hyatt	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2010-09-21 00:26:33 PDT

Created attachment 68197 [details] Patch

mitz

Comment 2 2010-09-21 00:31:34 PDT

Comment on attachment 68197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68197&action=review > WebCore/ChangeLog:7 > + to before/after-based. That way a vertical text table can have intrinsic padding built into the left/right > + direction (and this allows the base class logical padding methods on RenderBoxModelObject to safe to use). Missing a word here.

WebKit Review Bot

Comment 3 2010-09-21 01:22:27 PDT

http://trac.webkit.org/changeset/67930 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/67929 http://trac.webkit.org/changeset/67930

Adam Barth

Comment 4 2010-09-21 02:25:19 PDT

http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r67931%20(21481)/results.html Tests where results did not match expected results: svg/W3C-SVG-1.1/filters-image-01-b.svg expected actual diff pretty diff svg/batik/filters/filterRegions.svg expected actual diff pretty diff svg/batik/paints/gradientLimit.svg expected actual diff pretty diff svg/custom/empty-merge.svg expected actual diff pretty diff svg/custom/feDisplacementMap-01.svg expected actual diff pretty diff svg/custom/image-with-transform-clip-filter.svg expected actual diff pretty diff svg/custom/mask-with-default-value.svg expected actual diff pretty diff svg/custom/recursive-filter.svg expected actual diff pretty diff svg/custom/resource-invalidate-on-target-update.svg expected actual diff pretty diff svg/filters/feColorMatrix-values.svg expected actual diff pretty diff svg/filters/feOffset.svg expected actual diff pretty diff svg/filters/filterRes.svg expected actual diff pretty diff svg/filters/filteredImage.svg expected actual diff pretty diff svg/filters/parent-children-with-same-filter.svg expected actual diff pretty diff svg/filters/subRegion-in-userSpace.svg expected actual diff pretty diff svg/filters/subRegion-one-effect.svg expected actual diff pretty diff svg/filters/subRegion-two-effects.svg expected actual diff pretty diff

Adam Barth

Comment 5 2010-09-21 02:26:17 PDT

Looks like it might be fixed in http://trac.webkit.org/changeset/67933

Adam Barth

Comment 6 2010-09-21 02:27:41 PDT

Actually, looks like the problem was caused by https://bugs.webkit.org/show_bug.cgi?id=45612. Sorry for the noise.

Dave Hyatt

Comment 7 2010-09-21 08:48:21 PDT

Fixed.

Note You need to log in before you can comment on or make changes to this bug.