| Summary: | [Qt] PluginStrategy implementation is broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | kling, webkit-ews, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Bug Depends on: | 45857 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Balazs Kelemen
2010-09-20 02:35:51 PDT
Created attachment 68089 [details]
proposed patch
Attachment 68089 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/qt/WebCoreSupport/WebPlatformStrategies.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp"
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
> If any of these errors are false positives, please file a bug against check-webkit-style.
Sort orders these in the same order so maybe it is a check-webkit-syle bug.
Attachment 68089 [details] did not build on qt: Build output: http://queues.webkit.org/results/4030081 Finally I have realized that check-webkit-style expects system style includes after normal ones. (I have created a bug for the style guideline page that is ambigous: https://bugs.webkit.org/show_bug.cgi?id=46099). I could fix the include order before commit. Comment on attachment 68089 [details] proposed patch Clearing flags on attachment: 68089 Committed r68039: <http://trac.webkit.org/changeset/68039> All reviewed patches have been landed. Closing bug. |