Bug 46065

Summary: Unify implementation of ToInt32 and ToUInt32, don't use fmod.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch oliver: review+

Gavin Barraclough
Reported 2010-09-19 17:27:03 PDT
These methods implement the same conversion (see discussion in the notes of sections of 9.5 and 9.6 of the spec), only differing in how the result is interpreted.
Attachments
The patch (314.46 KB, patch)
2010-09-19 18:06 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-09-19 18:06:42 PDT
Created attachment 68043 [details] The patch
Gavin Barraclough
Comment 2 2010-09-19 18:08:20 PDT
Shows as a slight perf improvement on SunSpider, but probably just noise.
Oliver Hunt
Comment 3 2010-09-19 18:15:54 PDT
Comment on attachment 68043 [details] The patch r=me fix the flaoting typo in the comments
Gavin Barraclough
Comment 4 2010-09-19 18:35:45 PDT
fixed in r67825
Note You need to log in before you can comment on or make changes to this bug.