Summary: | Add infrastructure towards detecting change log diffs that aren't at the top of the ChangeLog | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, cjerdonek, ddkilzer, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 46061 | ||||||
Attachments: |
|
Description
Daniel Bates
2010-09-19 12:50:19 PDT
Created attachment 68036 [details]
Patch
This looks very useful. Sadly, I don't speak Perl. Comment on attachment 68036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68036&action=review > WebKitTools/Scripts/VCSUtils.pm:1575 > + my $changeLog = fixChangeLogPatch($patch); Variable name should note it's a reference to a hash. Maybe $changeLogHash. > WebKitTools/Scripts/svn-apply:319 > + my $changeLog = fixChangeLogPatch($patch); Ditto. > WebKitTools/Scripts/svn-create-patch:236 > + my $changeLog = fixChangeLogPatch($patch); Ditto. > WebKitTools/Scripts/svn-unapply:161 > + my $changeLog = fixChangeLogPatch($patch); Ditto. > WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:4 > +# Copyright (C) Research in Motion Limited 2010. All Rights Reserved. Shouldn't the year of the copyright be after the "(C)"? r=me with the variable name changes. (In reply to comment #3) > (From update of attachment 68036 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68036&action=review > > > WebKitTools/Scripts/VCSUtils.pm:1575 > > + my $changeLog = fixChangeLogPatch($patch); > > Variable name should note it's a reference to a hash. Maybe $changeLogHash. > Will change before I land. > > WebKitTools/Scripts/svn-apply:319 > > + my $changeLog = fixChangeLogPatch($patch); > > Ditto. > Will change before I land. > > WebKitTools/Scripts/svn-create-patch:236 > > + my $changeLog = fixChangeLogPatch($patch); > > Ditto. > Will change before I land. > > WebKitTools/Scripts/svn-unapply:161 > > + my $changeLog = fixChangeLogPatch($patch); > > Ditto. > Will change before I land. > > WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:4 > > +# Copyright (C) Research in Motion Limited 2010. All Rights Reserved. > > Shouldn't the year of the copyright be after the "(C)"? The RIM copyright string uses this explicit order. Committed r69177: <http://trac.webkit.org/changeset/69177> |