Bug 4604

Summary:

LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

Darin Adler <darin>

Status:

VERIFIED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
proposed patch	darin: review+
proposed patch, minus annoying comment	darin: review+

mitz

Reported 2005-08-23 10:36:02 PDT

-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout I noticed it while browsing the code, so no fancy "leaks" output here.

Attachments
proposed patch (673 bytes, patch) 2005-08-23 10:37 PDT, mitz	darin: review+	Details Formatted Diff Diff
proposed patch, minus annoying comment (625 bytes, patch) 2005-08-23 10:54 PDT, mitz	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2005-08-23 10:37:43 PDT

Created attachment 3537 [details] proposed patch

Darin Adler

Comment 2 2005-08-23 10:46:52 PDT

Comment on attachment 3537 [details] proposed patch That comment you copied and pasted really annoys me. Just needed to say that. Anyway, on your change, r=me!

Darin Adler

Comment 3 2005-08-23 10:47:15 PDT

Need to get this leak fix into Radar too now!

mitz

Comment 4 2005-08-23 10:54:34 PDT

Created attachment 3538 [details] proposed patch, minus annoying comment

Darin Adler

Comment 5 2005-08-23 14:37:12 PDT

In Radar as <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604).

Note You need to log in before you can comment on or make changes to this bug.