Bug 46021

Summary:

Add NoStaticTables attributes to IDLs of FileSystem API for Worker support

Product:

WebKit

Reporter:

Kinuko Yasuda <kinuko>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dumi, jianli, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

42903

Attachments:

Description	Flags
Patch	none
Patch	levin: review+

Description Kinuko Yasuda 2010-09-17 17:33:48 PDT

FileSystem API IDL files must have NoStaticTables to support workers.

Comment 1 Kinuko Yasuda 2010-09-17 17:40:19 PDT

Created attachment 67980 [details]
Patch

Comment 2 David Levin 2010-09-17 17:46:01 PDT

Comment on attachment 67980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67980&action=prettypatch

Mostly looks good. I had a few question about things that I like to understand before r+'ing. (If anyone else understands them and wants to r+, that is fine with me.)

> WebCore/ChangeLog:8
> +        Also changed their module from storage to fileapi.

Why?

> WebCore/ChangeLog:17
> +        * fileapi/ErrorCallback.idl:

A few of these idl's including this one didn't get NoStaticTables added to them. Why? (A ChangeLog comment on these file would be nice to explain it.)

Comment 3 Kinuko Yasuda 2010-09-17 18:00:43 PDT

Created attachment 67983 [details]
Patch

Comment 4 Kinuko Yasuda 2010-09-17 18:05:00 PDT

(In reply to comment #2)
> (From update of attachment 67980 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67980&action=prettypatch
> 
> Mostly looks good. I had a few question about things that I like to understand before r+'ing. (If anyone else understands them and wants to r+, that is fine with me.)
> 
> > WebCore/ChangeLog:8
> > +        Also changed their module from storage to fileapi.
> 
> Why?

I dropped this change (again) from this patch as it might be irrelevant.
(I moved them from WebCore/storage to WebCore/fileapi in r66586 but haven't changed the module name, and I thought it might be better to change the module name too.)

> > WebCore/ChangeLog:17
> > +        * fileapi/ErrorCallback.idl:
> 
> A few of these idl's including this one didn't get NoStaticTables added to them. Why? (A ChangeLog comment on these file would be nice to explain it.)

Added a comment in ChangeLog - Callback interfaces are implemented differently and NoStaticTables has no effect on them.  (That's my understanding - no other callbacks idl seem to have NoStaticTables.)

Comment 5 David Levin 2010-09-17 18:19:20 PDT

Comment on attachment 67983 [details]
Patch

Thanks!

Comment 6 Kinuko Yasuda 2010-09-20 20:37:38 PDT

Committed r67917: <http://trac.webkit.org/changeset/67917>