Bug 45996

Summary: Remove passing animation tests from Chromium's test_expectations.txt
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch jamesr: review+, commit-queue: commit-queue-

Mihai Parparita
Reported 2010-09-17 14:18:19 PDT
Remove passing animation tests from Chromium's test_expectations.txt
Attachments
Patch (2.90 KB, patch)
2010-09-17 14:18 PDT, Mihai Parparita 		jamesr: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-09-17 14:18:55 PDT
Created attachment 67949 [details] Patch
Mihai Parparita
Comment 2 2010-09-17 14:19:31 PDT
James, mind reviewing this?
James Robinson
Comment 3 2010-09-17 14:21:33 PDT
Comment on attachment 67949 [details] Patch Sure!
WebKit Commit Bot
Comment 4 2010-09-18 15:36:54 PDT
Comment on attachment 67949 [details] Patch Rejecting patch 67949 from commit-queue. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'James Robinson', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 succeeded at 1123 (offset -5 lines). Hunk #2 FAILED at 2595. Hunk #3 succeeded at 2985 (offset -39 lines). 1 out of 3 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Full output: http://queues.webkit.org/results/4001049
Adam Barth
Comment 5 2010-09-18 15:39:51 PDT
Comment on attachment 67949 [details] Patch I'll land this for you.
Adam Barth
Comment 6 2010-09-18 15:43:59 PDT
Committed r67793: <http://trac.webkit.org/changeset/67793>
Mihai Parparita
Comment 7 2010-09-18 19:55:10 PDT
(In reply to comment #5) > I'll land this for you. Thanks!
Note You need to log in before you can comment on or make changes to this bug.