Bug 45985

Summary: Add bool wrapper for WebKit2 API
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sullivan: review+

Sam Weinig
Reported 2010-09-17 12:26:28 PDT
Add bool wrapper for WebKit2 API
Attachments
Patch (5.30 KB, patch)
2010-09-17 12:27 PDT, Sam Weinig 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-09-17 12:27:13 PDT
Created attachment 67934 [details] Patch
WebKit Review Bot
Comment 2 2010-09-17 12:29:13 PDT
Attachment 67934 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKAPICast.h:68: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:99: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
John Sullivan
Comment 3 2010-09-17 12:31:27 PDT
Comment on attachment 67934 [details] Patch r+, assuming the style complaints are bogus (or you fix them).
Sam Weinig
Comment 4 2010-09-17 12:48:33 PDT
Landed in http://trac.webkit.org/changeset/67738.
Note You need to log in before you can comment on or make changes to this bug.