Bug 45961

Summary: Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports resource as not cached to InspectorController.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
yurys: review+
[PATCH] Same with willSendRequest not being issued for cached resources.
none
[PATCH] Simpler solution. yurys: review+

Pavel Feldman
Reported 2010-09-17 06:49:23 PDT
There is one path in control flow that leads to resource's being reported as not cached. Patch to follow.
Attachments
[PATCH] Proposed change. (4.59 KB, patch)
2010-09-17 06:56 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
[PATCH] Same with willSendRequest not being issued for cached resources. (14.36 KB, patch)
2010-09-17 07:26 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Simpler solution. (4.80 KB, patch)
2010-09-17 08:38 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-09-17 06:56:02 PDT
Created attachment 67907 [details] [PATCH] Proposed change.
Pavel Feldman
Comment 2 2010-09-17 07:26:54 PDT
Created attachment 67908 [details] [PATCH] Same with willSendRequest not being issued for cached resources.
Pavel Feldman
Comment 3 2010-09-17 08:38:29 PDT
Created attachment 67909 [details] [PATCH] Simpler solution. This one looks more hacky, but is indeed better since it does not introduce unnecessary complexity.
Pavel Feldman
Comment 4 2010-09-17 09:03:10 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorResource.cpp M WebCore/inspector/InspectorResource.h M WebCore/loader/FrameLoader.cpp Committed r67709
Alexey Proskuryakov
Comment 5 2010-09-17 09:05:20 PDT
I've read through the bug and the patch, and I'm confused. The bug seems to be about a problem in FrameLoader, and the patch doesn't fix it, correct? Can the problem have other consequences, perhaps outside Inspector? Should loadedResourceFromMemoryCache() be renamed to maybeLoadedResourceFromMemoryCacheUnlessSomethingHappened()?
Pavel Feldman
Comment 6 2010-09-17 09:15:12 PDT
(In reply to comment #5) > I've read through the bug and the patch, and I'm confused. The bug seems to be about a problem in FrameLoader, and the patch doesn't fix it, correct? > > Can the problem have other consequences, perhaps outside Inspector? Should loadedResourceFromMemoryCache() be renamed to maybeLoadedResourceFromMemoryCacheUnlessSomethingHappened()? I believe this was inspector's problem. We are still loading resource off cache.
Note You need to log in before you can comment on or make changes to this bug.