Bug 45929 – Support generating a FormData object based on the data in an existing <form>

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Jian Li]

Support generating a FormData object based on the data in an existing <form>, like:
    new FormData(formDataElement)

[Jian Li]

Created attachment 67855 [details]
Proposed Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 67855 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67855&action=prettypatch

> WebCore/html/DOMFormData.cpp:45
> +    appendForm(form);

wouldn't having two separate constructors be cleaner?  then you wouldn't
need the form null check inside of appendForm.

[Jian Li]

Created attachment 68110 [details]
Proposed Patch

Changed to have a separate constructor.

[Adam Barth]

Comment on attachment 68110 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68110&action=review

Is this from some spec?

> WebCore/html/DOMFormData.cpp:50
> +    if (form)

Prefer early return.

> WebCore/html/DOMFormData.h:55
>      DOMFormData(const TextEncoding&);
> +    DOMFormData(HTMLFormElement*);

These need to be marked "explicit".

[Jian Li]

(In reply to comment #4)
> (From update of attachment 68110 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68110&action=review
> 
> Is this from some spec?
> 
Not yet. But it will be added to the XHR Level 2 spec soon since everyone seems to agree on this. FF is also adding this support.

[Jian Li]

All fixed and landed at http://trac.webkit.org/changeset/69349.