Bug 45928

Summary:	Style bot shouldn't be telling developers to put "using namespace foo" in a header
Product:	WebKit	Reporter:	Brian Weinstein <bweinstein>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	abarth, dbates, eric, levin
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	PC
OS:	OS X 10.5

Brian Weinstein

Reported 2010-09-16 15:43:13 PDT

The style bot is current telling developers to put "using namespace foo" in headers, when it shouldn't. Twice this has caused build breakages on Windows within the past week. http://trac.webkit.org/changeset/67660 was fixed by http://trac.webkit.org/changeset/67671 was the most recent breakage/fix.

Attachments
Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-09-16 15:51:33 PDT

Thanks for the report.

Note You need to log in before you can comment on or make changes to this bug.