Bug 45867

Summary: Style bot complains about cairo forward declaration naming
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Cairo
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue none

Martin Robinson
Reported 2010-09-15 19:20:59 PDT
Typical errors take the form: WebCore/platform/DragImage.h:51: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] We probably just need to add an exclusion for cairo typedefs.
Attachments
Patch for this issue (2.81 KB, patch)
2010-09-16 16:29 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-09-16 16:29:21 PDT
Created attachment 67858 [details] Patch for this issue
Martin Robinson
Comment 2 2010-09-17 10:20:21 PDT
Comment on attachment 67858 [details] Patch for this issue Clearing flags on attachment: 67858 Committed r67722: <http://trac.webkit.org/changeset/67722>
Martin Robinson
Comment 3 2010-09-17 10:20:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.