Summary: | run-webkit-tests should not print "actual expected diffs" when there are no diffs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | Tools / Tests | Assignee: | Dave Hyatt <hyatt> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ben.lamonica | ||||||
Priority: | P4 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2005-08-22 04:31:51 PDT
Created attachment 3516 [details]
don't print layout diffs unless necessary
This is a fix for the first part of this bug (run-webkit-tests should not print
"actual expected diffs" when there are no diffs)
Forgot to mention that the patch also assures that all rows in the result tables have the same number of td-cells. Comment on attachment 3516 [details]
don't print layout diffs unless necessary
Looks like this patch results in two extra cells when $pixelTests is 0. Should
fix that. Otherwise, seems great.
Created attachment 3519 [details]
address darin's comments
Comment on attachment 3519 [details]
address darin's comments
r=me
|