Bug 4584

Summary:

run-webkit-tests should not print "actual expected diffs" when there are no diffs

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ben.lamonica

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
don't print layout diffs unless necessary	darin: review-
address darin's comments	darin: review+

Eric Seidel (no email)

Reported 2005-08-22 04:31:51 PDT

run-webkit-tests should not print "actual expected diffs" when there are no diffs Sometimes when using the --pixel tests, there are failures only on the pixel side of things, which still causes the resulting failure to print "actual expected diffs" and link to the render dump, even though they are all empty. Furthermore, run-webkit-tests could differentiate between a render tree dump failure and a pixel dump failure when printing the -> failed messages (-> failed (pixel) ) , and also could include the percentage difference after ->failed (->failed (pixel: 15.5%), etc.)

Attachments
don't print layout diffs unless necessary (2.15 KB, patch) 2005-08-22 08:50 PDT, Tobias Lidskog	darin: review-	Details Formatted Diff Diff
address darin's comments (1.75 KB, patch) 2005-08-22 11:24 PDT, Tobias Lidskog	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tobias Lidskog

Comment 1 2005-08-22 08:50:36 PDT

Created attachment 3516 [details] don't print layout diffs unless necessary This is a fix for the first part of this bug (run-webkit-tests should not print "actual expected diffs" when there are no diffs)

Tobias Lidskog

Comment 2 2005-08-22 08:53:17 PDT

Forgot to mention that the patch also assures that all rows in the result tables have the same number of td-cells.

Darin Adler

Comment 3 2005-08-22 11:14:17 PDT

Comment on attachment 3516 [details] don't print layout diffs unless necessary Looks like this patch results in two extra cells when $pixelTests is 0. Should fix that. Otherwise, seems great.

Tobias Lidskog

Comment 4 2005-08-22 11:24:44 PDT

Created attachment 3519 [details] address darin's comments

Darin Adler

Comment 5 2005-08-22 11:31:06 PDT

Comment on attachment 3519 [details] address darin's comments r=me

Note You need to log in before you can comment on or make changes to this bug.