Summary: | Command.tool should not need to be a WebKitPatch subclass | ||
---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | abarth, dpranke, mihaip |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 |
Description
Eric Seidel (no email)
2010-09-15 14:39:55 PDT
(In reply to comment #0) > We need to break out a Tool subclass of WebKitPatch so that all the various commands which assume they have a self.tool.bugs, self.tool.scm, etc. can be run using something other than webkit-patch. I actually meant "Steps" not Commands. I don't expect other tools will re-use webkit-patch Command objects, but they could. Having a self.tool is pretty central to how the webkitpy command infrastructure works though. |