Bug 45837

Summary: Use free variable analysis to improve activation performance
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2010-09-15 14:20:19 PDT
Use free variable analysis to improve activation performance
Attachments
Patch (30.27 KB, patch)
2010-09-15 14:24 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-09-15 14:24:54 PDT
Created attachment 67715 [details] Patch
Geoffrey Garen
Comment 2 2010-09-15 14:52:54 PDT
Comment on attachment 67715 [details] Patch 214 void useVariable(const Identifier* ident, bool isEval) Since there's only one caller to this function, and it just compares the property name to the global eval property name, I think you could remove the isEval flag and have this function compute it automatically. 220 void collectFreeVariables(Scope* oldScope, bool shouldTrackCapturedVariables) I think this would be clearer if you named "oldScope" "nestedScope" instead. Might be worth a comment defining what a "captured" variable is. r=me
Oliver Hunt
Comment 3 2010-09-15 17:05:33 PDT
Committed r67583: <http://trac.webkit.org/changeset/67583>
Note You need to log in before you can comment on or make changes to this bug.