Bug 45821

Summary: Remove extraneous RenderObject traversal.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2010-09-15 09:21:28 PDT
Remove extraneous RenderObject traversal.
Attachments
Patch (2.15 KB, patch)
2010-09-15 09:29 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-09-15 09:29:08 PDT
Created attachment 67683 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-09-15 09:31:53 PDT
The code being removed always exits in the first iteration of the loop, because in the context of this call, node->renderer()->node() != 0 is always true. Ran tests to make sure there are no regressions.
Dave Hyatt
Comment 3 2010-09-16 09:54:21 PDT
Comment on attachment 67683 [details] Patch r=me... wish I knew what the original code was trying to do, but it's definitely just equivalent to node->dispatchEvent.
Dimitri Glazkov (Google)
Comment 4 2010-09-17 09:14:11 PDT
Comment on attachment 67683 [details] Patch Clearing flags on attachment: 67683 Committed r67710: <http://trac.webkit.org/changeset/67710>
Dimitri Glazkov (Google)
Comment 5 2010-09-17 09:14:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.