Bug 45807

Summary:

Web Inspector: Multiline console does not work on Windows / Linux

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andyearnshaw, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed fix.	none

Pavel Feldman

Reported 2010-09-14 23:46:31 PDT

Reason: Alt+Enter is handled before it gets to the inspected page. I'll add Ctrl+Enter handler and make it work on all platforms. As a result, Mac users get Alt | Ctrl, Linux and Windows users get Ctrl+Enter.

Attachments
[PATCH] Proposed fix. (951 bytes, patch) 2010-09-14 23:49 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-09-14 23:49:11 PDT

Created attachment 67648 [details] [PATCH] Proposed fix.

WebKit Commit Bot

Comment 2 2010-09-15 02:44:47 PDT

Comment on attachment 67648 [details] [PATCH] Proposed fix. Clearing flags on attachment: 67648 Committed r67545: <http://trac.webkit.org/changeset/67545>

WebKit Commit Bot

Comment 3 2010-09-15 02:44:51 PDT

All reviewed patches have been landed. Closing bug.

Andy E

Comment 4 2010-11-05 06:00:02 PDT

Why isn't it Shift + Enter? Most instant messaging apps use Shift+Enter for multi-line messages and Firefox's console uses the same combination. Shift+Enter would feel more natural for most Windows users, please change this.

Pavel Feldman

Comment 5 2010-11-05 07:27:25 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/StoragePanel.js M WebCore/inspector/front-end/inspector.js Committed r71413 (added shift+Enter modifier as a drive-by)

Note You need to log in before you can comment on or make changes to this bug.