Bug 45797

Summary:

[BREWMP] Port TextCodec

Product:

WebKit

Reporter:

Kwang Yul Seo <skyul>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beergun

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

33564

Attachments:

Description	Flags
Patch	none
Patch	none

Kwang Yul Seo

Reported 2010-09-14 17:57:12 PDT

Implement TextCodec with Brew MP's ICharsetConv.

Attachments
Patch (13.19 KB, patch) 2010-09-14 18:10 PDT, Kwang Yul Seo	no flags	Details Formatted Diff Diff
Patch (13.22 KB, patch) 2010-10-01 14:45 PDT, Kwang Yul Seo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kwang Yul Seo

Comment 1 2010-09-14 18:10:40 PDT

Created attachment 67628 [details] Patch Support only UTF-8 for now.

Kwang Yul Seo

Comment 2 2010-10-01 14:45:27 PDT

Created attachment 69523 [details] Patch Append L'?' on AEE_BADITEM when stopOnError is set. Otherwise, Acid 3 test 70 fails.

Kwang Yul Seo

Comment 3 2010-10-14 17:41:36 PDT

Refer to https://brewmobileplatform.qualcomm.com/devnet/resources/devEx/library/references/c/bmp_sdk_api_ref/HTML/APIReference/system/Text/Interfaces/ICharsetConv/ICharsetConv.htm for ICharsetConv

Kent Tamura

Comment 4 2010-10-14 17:56:03 PDT

Comment on attachment 69523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69523&action=review > WebCore/platform/text/brew/TextCodecBrew.cpp:195 > + This blank line seems unnecessary.

Kwang Yul Seo

Comment 5 2010-10-16 14:05:11 PDT

Manually committed r69917: http://trac.webkit.org/changeset/69917

Kwang Yul Seo

Comment 6 2010-10-16 14:05:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.