Bug 45783

Summary:

LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jorlow, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Steve Block 2010-09-14 14:39:18 PDT

Fix LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html contains a race condition so is flaky.

This test synchronously navigates the page to a new URL from its main script file. This navigation causes WebView.onPageFinished() to be called for the test page. The problem is that this may occur before js-test-post.js, which is included by the test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a result, the test is incorrectly deemed to have finished as soon as the navigation is started and the output will therefore be incorrect.

Comment 1 Steve Block 2010-09-14 14:53:30 PDT

Created attachment 67610 [details]
Patch

Comment 2 WebKit Commit Bot 2010-09-15 03:06:20 PDT

Comment on attachment 67610 [details]
Patch

Clearing flags on attachment: 67610

Committed r67546: <http://trac.webkit.org/changeset/67546>

Comment 3 WebKit Commit Bot 2010-09-15 03:06:25 PDT

All reviewed patches have been landed.  Closing bug.