Summary: | [Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | WebKit Qt | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | dbates, eric, hausmann, kenneth, kling, pierre.rossi, tonikitoo, yongjun.zhang | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Carlson
2010-09-13 20:56:32 PDT
Created attachment 67517 [details]
patch
Comment on attachment 67517 [details]
patch
LGTM.
r=me
(In reply to comment #2) > (From update of attachment 67517 [details]) > LGTM. > r=me I am assuming WebCore/dom/ActiveDOMObject.h gets included by someone... Temporary fix landed in http://trac.webkit.org/changeset/67440 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 67517 [details] [details]) > > LGTM. > > r=me > > I am assuming WebCore/dom/ActiveDOMObject.h gets included by someone... So, it will get included by WorkerThread.h, which includes WorkerRunLoop.h which includes ScriptExecutionContext.h, which includes ActiveDOMObject.h I was a bit to quick when reviewing this. The enum value JavaScriptPaused was renamed to JavaScriptDebuggerPaused. I missed that in the review. My mistake. I will be more cautious. Committed enum value fix up in changeset 67442 <http://trac.webkit.org/changeset/67442>. Attachment 67517 [details] was posted by a committer and has review+, assigning to Eric Carlson for commit.
I committed https://bugs.webkit.org/attachment.cgi?id=67517, and dbates fixed it in http://trac.webkit.org/changeset/67442 when my change didn't actually compile :-( This bug is about getting a real fix into DumpRenderTreeSupportQt::suspendActiveDOMObjects instead of the hack I added which hard codes the reason for suspension. This actually looks like dead code by now. |