Bug 45689

Summary:

Add option to conditionally compile smooth scrolling support

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebCore Misc.

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, pkasting

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	levin: review+, fishd: commit-queue-

Darin Fisher (:fishd, Google)

Reported 2010-09-13 11:18:35 PDT

Add option to conditionally compile smooth scrolling support Some ports may not want to build with smooth scrolling enabled.

Attachments
v1 patch (3.28 KB, patch) 2010-09-13 11:25 PDT, Darin Fisher (:fishd, Google)	levin: review+ fishd: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2010-09-13 11:25:37 PDT

Created attachment 67437 [details] v1 patch

Darin Fisher (:fishd, Google)

Comment 2 2010-09-13 11:27:05 PDT

This patch disables smooth scrolling on all platforms. I did that because there are enough bugs with the feature that I don't think it is ready for prime time yet. For example, it changes the way we fire onscroll events, which causes problems for some web sites (observable on code.google.com's issue tracker).

Darin Fisher (:fishd, Google)

Comment 3 2010-09-13 11:57:14 PDT

Landed as http://trac.webkit.org/changeset/67401

Darin Fisher (:fishd, Google)

Comment 4 2010-09-13 14:09:03 PDT

Landed on the chromium/517 branch as well: http://trac.webkit.org/changeset/67410

Note You need to log in before you can comment on or make changes to this bug.