Summary: | Web Inspector: [Resources panel] [HAR] Need a way to save timing data. | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, sullivan, timothy, yurys | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Pavel Feldman
2010-09-13 06:08:07 PDT
Created attachment 67559 [details]
patch
Comment on attachment 67559 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=67559&action=prettypatch > WebCore/inspector/front-end/HAREntry.js:163 > + return start === -1 ? -1 : Math.round(timing[end] - timing[start]); start === -1 is not needed Created attachment 67565 [details]
patch to land
- Changed check for timings[start] in HAREntry._interval()
- Return -1 instead of 0 for timings.connect if connection reused.
Committed manually r67474: http://trac.webkit.org/changeset/67474 See also https://bugs.webkit.org/show_bug.cgi?id=45764 for export of HAR data. Bug description requests that HAR data is exportable in the Web Inspector. Reopening. *** Bug 45764 has been marked as a duplicate of this bug. *** Created attachment 67785 [details]
patch
- Added support to export HAR file from resource panel (disabled in Preferences by default until raw headers & cookies available per pfeldman's request)
- Added support for top-level HAR archive (we used to only support HAREntry)
N.B.: the unreadable name of file we offer for download looks to be an immanent effect of the underlying implementation: we use blobs to construct contents of file on the client side, and have no way to apply Content-disposition there or affect file name in the resulting blob URL returned by createBlobURL().
Created attachment 67788 [details]
patch
- Fixed binary diff
Committed manually r67615: http://trac.webkit.org/changeset/67615 Comment on attachment 67559 [details] patch Cleared Yury Semikhatsky's review+ from obsolete attachment 67559 [details] so that this bug does not appear in http://webkit.org/pending-commit. Created attachment 75336 [details]
patch
This patch restores HAR export functionality that used to be in Resource panel but was lost during transitioning to Network panel.
Comment on attachment 75336 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=75336&action=review > WebCore/inspector/front-end/NetworkPanel.js:1312 > + get resource() no need for this getter. Created attachment 75341 [details]
patch to land
- removed NetworkDataGridNode.get resource(), directly access NetworkDataGridNode._resource instead
- removed trailing whitespace
Comment on attachment 67788 [details] patch Cleared Pavel Feldman's review+ from obsolete attachment 67788 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 75336 [details] patch Cleared Pavel Feldman's review+ from obsolete attachment 75336 [details] so that this bug does not appear in http://webkit.org/pending-commit. This is now available for all platforms as Network panel -> context menu -> Copy as HAR, so closing bug. |