Bug 45662 – Web Inspector: [Resources panel] Should be easy to copy data.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

In Firebug, when you right-click a URL, you get a context menu with options to copy the location, copy the request headers, or copy the response headers. HttpWatch is even better--it has separate panels for headers, cookies, query string, and postdata. You can go to any panel, and see the data split into a table of name/value pairs. Right click on any value and you get the option to copy the value, the name/value pair, or all the rows in the panel. This is extremely useful when someone asks you to send them the value of a certain header or post field, which happens to me a lot.

[Annie Sullivan]

Created attachment 89893 [details]
Patch

To get the request/response headers as plain text, I implemented get requestHeadersText() and get responseHeadersText() for WebInspector.Resource, similar to the getters for sorted headers. Let me know if there's a better way to do this.

[Yury Semikhatsky]

Comment on attachment 89893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89893&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1003
> +                contextMenu.appendItem(WebInspector.UIString("Copy request headers"), this._exportRequestHeaders.bind(this, resource));

New UI strings should be added to Source/WebCore/English.lproj/localizedStrings.js.

[Pavel Feldman]

Comment on attachment 89893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89893&action=review

Overall looks good. You need an entry in localizedStrings.js as Yury suggests to land this.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1023
>          InspectorFrontendHost.copyText(JSON.stringify(har));

It used to export values, now it copies them, so the name of the method is misleading. Do not reuse it.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1026
> +    _exportLocation: function(resource)

I.e. should be _copyLocation, etc.

> Source/WebCore/inspector/front-end/Resource.js:429
> +            this._requestHeadersText += key + ": " + this.requestHeaders[key] + '\n'; 

Please use double quotes.

> Source/WebCore/inspector/front-end/Resource.js:510
> +            this._responseHeadersText += key + ": " + this.responseHeaders[key] + '\n'; 

ditto.

[Annie Sullivan]

Comment on attachment 89893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89893&action=review

>> Source/WebCore/inspector/front-end/NetworkPanel.js:1023
>>          InspectorFrontendHost.copyText(JSON.stringify(har));
> 
> It used to export values, now it copies them, so the name of the method is misleading. Do not reuse it.

Done.

>> Source/WebCore/inspector/front-end/NetworkPanel.js:1026
>> +    _exportLocation: function(resource)
> 
> I.e. should be _copyLocation, etc.

Done.

>> Source/WebCore/inspector/front-end/Resource.js:429
>> +            this._requestHeadersText += key + ": " + this.requestHeaders[key] + '\n'; 
> 
> Please use double quotes.

Done.

>> Source/WebCore/inspector/front-end/Resource.js:510
>> +            this._responseHeadersText += key + ": " + this.responseHeaders[key] + '\n'; 
> 
> ditto.

Done.

[Annie Sullivan]

Created attachment 90647 [details]
Patch: Addresses comments and adds localized strings.

[Pavel Feldman]

Comment on attachment 90647 [details]
Patch: Addresses comments and adds localized strings.

I think you need to merge this code with the tip of the tree. Also, note that there is a way to copy headers via switching to raw view + selecting + copypasting.

[Annie Sullivan]

Created attachment 90734 [details]
New patch, merged with tip of tree

[Annie Sullivan]

(In reply to comment #6)
> (From update of attachment 90647 [details])
> I think you need to merge this code with the tip of the tree. Also, note that there is a way to copy headers via switching to raw view + selecting + copypasting.

Yes, it's possible to do this, but it's really hard to get all the headers without truncating something from the top or bottom or accidentally including some of the text above/below the headers, especially on a laptop with a smaller screen and no mouse. I think this is why both Firebug and HttpWatch provide context menu options for this. It's a very useful feature for quickly getting information into a bug or email.

[Pavel Feldman]

Comment on attachment 90734 [details]
New patch, merged with tip of tree

Clearing flags on attachment: 90734

Committed r84778: <http://trac.webkit.org/changeset/84778>

[Pavel Feldman]

All reviewed patches have been landed.  Closing bug.