Bug 45636

Summary: Apply spec changes to InForeignContentMode
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2010-09-12 23:46:29 PDT
Apply spec changes to InForeignContentMode
Attachments
Patch (7.33 KB, patch)
2010-09-12 23:48 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.40 KB, patch)
2010-09-13 00:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-12 23:48:26 PDT
Created attachment 67361 [details] Patch
Eric Seidel (no email)
Comment 2 2010-09-12 23:58:05 PDT
Comment on attachment 67361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67361&action=prettypatch No update to the expectations needed? > WebCore/html/parser/HTMLTreeBuilder.cpp:2648 > + // FIXME: The spec adds the following condition before setting the > + // insertion mode. However, this condition causes an infinite loop. > + // if (insertionMode() == InForeignContentMode && m_tree.openElements()->hasOnlyHTMLElementsInScope()) Please file a spec bug (and ideally link it from the code or we'll never find it.)
Adam Barth
Comment 3 2010-09-13 00:01:18 PDT
The new tests pass, which means I don't need to update the results.
Adam Barth
Comment 4 2010-09-13 00:11:57 PDT
Created attachment 67367 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-09-13 02:19:53 PDT
Comment on attachment 67367 [details] Patch for landing Clearing flags on attachment: 67367 Committed r67372: <http://trac.webkit.org/changeset/67372>
WebKit Commit Bot
Comment 6 2010-09-13 02:19:57 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-09-13 02:45:32 PDT
http://trac.webkit.org/changeset/67372 might have broken Qt Linux Release minimal
Note You need to log in before you can comment on or make changes to this bug.