Bug 45628 – [WML] Fix build breaks when WML is enabled

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Gyuyoung Kim]

There are build breaks when WML is enabled.

[Gyuyoung Kim]

Created attachment 67354 [details]
Patch

[Dirk Schulze]

Comment on attachment 67354 [details]
Patch

How can r67355 be responsible for your build breakage? It's a qt only change in the patch.
Give more details in the ChangeLog. What breaks the WML build, how do you fixed it and so on.

[Gyuyoung Kim]

Created attachment 67371 [details]
Patch

Sorry for my poor expression in my patch. When wml is enabled, there are build breaks as below, 

======================================================================================================
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLAElement.cpp: In member function ‘virtual void WebCore::WMLAElement::defaultEventHandler(WebCore::Event*)’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLAElement.cpp:131: error: cannot convert ‘WebCore::Document*’ to ‘WebCore::Event*’ for argument ‘1’ to ‘void WebCore::handleLinkClick(WebCore::Event*, WebCore::Document*, const WTF::String&, const WTF::String&, bool)’
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp: In member function ‘virtual void WebCore::WMLInputElement::defaultEventHandler(WebCore::Event*)’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp:277: error: ‘class WebCore::Frame’ has no member named ‘doTextFieldCommandFromEvent’
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLAElement.cpp.o] Error 1
======================================================================================================
So, I make a patch for this build breaks. I add more comments in Changelog. :) 

Thank you.

[Kent Tamura]

Comment on attachment 67371 [details]
Patch

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 05912d0..5b61a98 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,19 @@
> [phone]  Gyuyoung Kim  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [WML] Fix a build break R67355 

This description is confusing.  This sounds like r67355 caused a WML build break.
Actually http://trac.webkit.org/changeset/67262 caused it, right?

[Gyuyoung Kim]

Created attachment 67374 [details]
Patch

Oops, my mistake. I modify Changelog again. If there are still wrong expression, please let me know.

Thank you.

[WebKit Commit Bot]

Comment on attachment 67374 [details]
Patch

Clearing flags on attachment: 67374

Committed r67395: <http://trac.webkit.org/changeset/67395>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.