Bug 45617

Summary:

Consolidate WebCore/bridge/npruntime_internal.h and WebCore/bindings/v8/npruntime_internal.h

Product:

WebKit

Reporter:

Simon Hausmann <hausmann>

Component:

Platform

Assignee:

Simon Hausmann <hausmann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, japhet, kling, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Reviewed by NOBODY (OOPS!)	kling: review+

Simon Hausmann

Reported 2010-09-12 10:38:11 PDT

These two files are currently duplicated. We should get rid of the copy in WebCore/bindings/v8

Attachments
Patch (3.50 KB, patch) 2010-09-12 10:39 PDT, Simon Hausmann	no flags	Details Formatted Diff Diff
Reviewed by NOBODY (OOPS!) (3.31 KB, patch) 2011-11-05 07:46 PDT, Simon Hausmann	kling: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Hausmann

Comment 1 2010-09-12 10:39:30 PDT

Created attachment 67337 [details] Patch

Adam Barth

Comment 2 2010-09-26 22:36:01 PDT

Comment on attachment 67337 [details] Patch Woah. You're blowing my mind.

WebKit Commit Bot

Comment 3 2010-09-26 23:00:24 PDT

Comment on attachment 67337 [details] Patch Rejecting patch 67337 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 67337]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=67337&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=45617&ctype=xml Processing 1 patch from 1 bug. Processing patch 67337 from bug 45617. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4028157

Eric Seidel (no email)

Comment 4 2010-12-14 01:56:53 PST

Comment on attachment 67337 [details] Patch Was this already landed? I wonder why they cq failed to apply?

Simon Hausmann

Comment 5 2011-11-05 07:46:33 PDT

(In reply to comment #4) > (From update of attachment 67337 [details]) > Was this already landed? I wonder why they cq failed to apply? It never landed. Strange :). Uploading a rebased patch.

Simon Hausmann

Comment 6 2011-11-05 07:46:53 PDT

Created attachment 113753 [details] Reviewed by NOBODY (OOPS!)

Simon Hausmann

Comment 7 2011-11-05 08:03:30 PDT

Committed r99353: <http://trac.webkit.org/changeset/99353>

Note You need to log in before you can comment on or make changes to this bug.