Summary: | Inline UTF8SequenceLength | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||||||
Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, commit-queue, darin, eric, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Patrick R. Gansterer
2010-09-11 08:52:12 PDT
Created attachment 67299 [details]
Patch
Comment on attachment 67299 [details]
Patch
Please update your ChangeLog to explain "why".
(In reply to comment #2) > (From update of attachment 67299 [details]) > Please update your ChangeLog to explain "why". Doesn't "inline" already explain it all? Comment on attachment 67299 [details] Patch (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 67299 [details] [details]) > > Please update your ChangeLog to explain "why". > Doesn't "inline" already explain it all? There is no real "why". It's only a cleanup. Does it make the code faster? Smaller? Easier to read? Created attachment 68003 [details]
Patch
Added a "to improve performance" in the ChangeLog.
Comment on attachment 68003 [details]
Patch
OK. So does this improve performance?
Created attachment 68371 [details] Changes used for testing > OK. So does this improve performance? I've done a quick performance test with this patch. I've got ~8% speed improvement on WinCE (time dropped from 2385 to 2203). (In reply to comment #8) > I've done a quick performance test with this patch. > I've got ~8% speed improvement on WinCE (time dropped from 2385 to 2203). Sorry to keep pushing on this, but did you try just calling the inline version as-is rather than merging them? I’d expect an even-better speed improvement if you just changed the call site in convertUTF8ToUTF16 and didn’t make the other changes. Created attachment 68378 [details] Patch (In reply to comment #9) > Sorry to keep pushing on this, but did you try just calling the inline version as-is rather than merging them? I’d expect an even-better speed improvement if you just changed the call site in convertUTF8ToUTF16 and didn’t make the other changes. I don't know why, but you're right! It's faster with the newest patch. (In reply to comment #10) > (In reply to comment #9) > > Sorry to keep pushing on this, but did you try just calling the inline version as-is rather than merging them? I’d expect an even-better speed improvement if you just changed the call site in convertUTF8ToUTF16 and didn’t make the other changes. > I don't know why, but you're right! It's faster with the newest patch. I believe I wrote the original function, and I followed the principle of inlining the hot part of the code and keeping the less-hot part out of line. This often makes things faster than just inlining everything. Seeing that your original patch reversed that decision, I asked you to measure. Thanks for the extra effort. Comment on attachment 68378 [details] Patch Clearing flags on attachment: 68378 Committed r68055: <http://trac.webkit.org/changeset/68055> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/68055 might have broken Qt Windows 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/68056 http://trac.webkit.org/changeset/68055 |