Bug 45538

Summary: [GTK] Fix warnings because of bad assignments in testatk.c
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Mario Sanchez Prada
Reported 2010-09-10 06:35:05 PDT
In testatk.c in testWebkitAtkListsOfItems, there are several places where AtkObject instances are expected and AtkText instances are passed instead, and viceversa, resulting in warning messages during compilation: ../../WebKit/gtk/tests/testatk.c: In function ‘testWebkitAtkListsOfItems’: ../../WebKit/gtk/tests/testatk.c:879: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:880: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:881: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:887: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:888: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:889: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:902: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:903: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:904: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:906: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:907: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:908: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ Attaching a patch to fix all these issues in brief...
Attachments
Patch (3.99 KB, patch)
2010-09-10 06:44 PDT, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2010-09-10 06:44:01 PDT
Created attachment 67177 [details] Patch This simple patch will fix those evil warnings
WebKit Commit Bot
Comment 2 2010-09-10 19:48:05 PDT
Comment on attachment 67177 [details] Patch Clearing flags on attachment: 67177 Committed r67270: <http://trac.webkit.org/changeset/67270>
WebKit Commit Bot
Comment 3 2010-09-10 19:48:09 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-09-10 20:17:21 PDT
http://trac.webkit.org/changeset/67270 might have broken GTK Linux 32-bit Release
Note You need to log in before you can comment on or make changes to this bug.