Bug 4553

Summary: QuartzSupport::CGPathToCFStringApplierFunction incorrect
Product: WebKit Reporter: Tobias Lidskog <tobiaslidskog>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch + updated tests
none
updated diff eric: review+

Tobias Lidskog
Reported 2005-08-21 03:21:42 PDT
Converting a CGPath to a string is done in an incorrect way. Quadratic curves (kCGPathElementAddQuadCurveToPoint) should result in two points, currently four points are printed. Cubic curves (kCGPathElementAddCurveToPoint) should result in three points, currently six points are printed.
Attachments
patch + updated tests (269.65 KB, patch)
2005-08-21 03:22 PDT, Tobias Lidskog 		no flags
DetailsFormatted DiffDiff
updated diff (266.16 KB, patch)
2005-08-21 19:41 PDT, Tobias Lidskog 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tobias Lidskog
Comment 1 2005-08-21 03:22:19 PDT
Created attachment 3490 [details] patch + updated tests
Tobias Lidskog
Comment 2 2005-08-21 19:41:40 PDT
Created attachment 3500 [details] updated diff The previous diff accidently included a patch for another bug as well.
Eric Seidel (no email)
Comment 3 2005-08-22 02:14:00 PDT
Comment on attachment 3500 [details] updated diff Wow. Yeah, serious oversight on my part. This was causing problems with the layout tests too... Thanks for the nice fix.
Note You need to log in before you can comment on or make changes to this bug.