Bug 45518
Summary: | rebaseline script looks for ImageDiff in wrong location on Linux | ||
---|---|---|---|
Product: | WebKit | Reporter: | Mike Lawther <mikelawther> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | dpranke |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Other | ||
OS: | Linux |
Mike Lawther
I tried running WebKitTools/Scripts/rebaseline-chromium-webkit-tests (after having run build-webkit --chromium).
The script said it could not find ImageDiff.
It was looking in WebKit/chromium/out/Release/image_diff but it was built in out/Release/ImageDiff.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Dirk Pranke
I think this is a result of us having two build variants going on at once. If you did build-webkit --chromium, I think you need to pass --use_drt to rebaseline-chromium-webkit-tests.
Mike Lawther
I had already guessed at trying that, but there's no such option?
$ rebaseline-chromium-webkit-tests --run-drt
Usage: rebaseline-chromium-webkit-tests [options]
rebaseline-chromium-webkit-tests: error: no such option: --run-drt
Sorry if I'm missing something obvious here.
The target platform used by rebaseline-chromium-webkit-tests is definitely chromium - I checked this by adding some logging to WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py
I had also previously tried adding --target-platform=chromium, although my reading of the script says this should be
My tree should be up-to-date (within a few hours or so)
$ svn info
Path: .
URL: http://svn.webkit.org/repository/webkit/trunk
Repository Root: http://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 67149
Node Kind: directory
Schedule: normal
Last Changed Author: dpranke@chromium.org
Last Changed Rev: 67149
Last Changed Date: 2010-09-10 12:25:51 +1000 (Fri, 10 Sep 2010)
Mike Lawther
Argh - you said --use_drt, I had tried --run-drt. Oops.
--use_drt does seem to work OK.
Thanks!