Bug 45509
| Summary: | REGRESSION: r61215 broke web views with transparent backgrounds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | hausmann, jarmo.backlund |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | OS X 10.5 | ||
Simon Fraser (smfr)
r61215 caused RenderView to paint the viewport background when the
document element's renderer is known to not fill opaquely paint
the entire viewport, i.e. more often than it did before.
This exposed a latent, long-standing bug which was introducted
in r14638 (the RenderCanvas -> RenderView rename), where a call
to view()->isTransparent() was not converted to frameView()->isTransparent(),
yet happened to still compile because of RenderObject::isTransparent().
This resulted in us painting the viewport background, even when
WebView clients explicitly said that they wanted a transparent
WebView.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
<rdar://problem/8142166>
Simon Fraser (smfr)
http://trac.webkit.org/changeset/67137
Simon Hausmann
*** Bug 46458 has been marked as a duplicate of this bug. ***
Simon Hausmann
<cherry-pick-for-backport: r67137>
Simon Hausmann
Revision r67137 cherry-picked into qtwebkit-2.1 with commit bf85131 <http://gitorious.org/webkit/qtwebkit/commit/bf85131>