Bug 45502

Summary: JSObjectSetPrivateProperty does not handle NULL values as it claims
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: JavaScriptCoreAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Major CC: abarth, aroben, eric, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch oliver: review+

Description Mark Rowe (bdash) 2010-09-09 16:18:31 PDT 
The headerdoc for JSObjectSetPrivateProperty claims that passing NULL as the value is valid.  In practice this leads to assertion failures with debug builds of JavaScriptCore.
Comment 1 Mark Rowe (bdash) 2010-09-09 16:22:57 PDT 
Created attachment 67113 [details]
Patch
Comment 2 Oliver Hunt 2010-09-09 16:24:55 PDT 
Comment on attachment 67113 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2010-09-09 18:12:35 PDT 
http://trac.webkit.org/changeset/67129 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67128
http://trac.webkit.org/changeset/67129
http://trac.webkit.org/changeset/67126
http://trac.webkit.org/changeset/67127
Comment 4 Eric Seidel (no email) 2010-10-13 12:27:18 PDT 
Attachment 67113 [details] was posted by a committer and has review+, assigning to Mark Rowe for commit.
Comment 5 Mark Rowe (bdash) 2010-10-13 12:30:09 PDT 
This was landed way back in r67129.