Bug 45490

Summary: Adopt shared control drawing for <video> controls on Windows
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, eric.carlson, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
shared-controls
none
shared-controls eric.carlson: review+

Jer Noble
Reported 2010-09-09 14:00:26 PDT
Windows Safari should use the shared control drawing used by Mac Safari on the <video> element.
Attachments
shared-controls (29.53 KB, patch)
2010-09-09 16:34 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
shared-controls (22.95 KB, patch)
2010-09-10 14:10 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2010-09-09 14:00:38 PDT
<rdar://problem/6293979>
Jer Noble
Comment 2 2010-09-09 16:34:08 PDT
Created attachment 67114 [details] shared-controls
WebKit Review Bot
Comment 3 2010-09-09 16:37:12 PDT
Attachment 67114 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/rendering/RenderMediaControls.cpp:90: Use 0 instead of NULL. [readability/null] [5] WebCore/rendering/RenderMediaControls.h:39: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 4 2010-09-09 17:48:04 PDT
I'll fix the style errors before checking in.
WebKit Review Bot
Comment 5 2010-09-10 04:06:02 PDT
Attachment 67114 [details] did not build on win: Build output: http://queues.webkit.org/results/3916341
Jer Noble
Comment 6 2010-09-10 14:10:48 PDT
Created attachment 67234 [details] shared-controls
Eric Carlson
Comment 7 2010-09-10 14:57:50 PDT
Comment on attachment 67234 [details] shared-controls > -#if SAFARI_THEME_VERSION >= 4 This shouldn't be necessary any more. r=me
Jer Noble
Comment 8 2010-09-10 16:56:56 PDT
Committed r67251: <http://trac.webkit.org/changeset/67251>
Note You need to log in before you can comment on or make changes to this bug.