| Summary: | Use String::fromUTF8 instead of UTF8Encoding().decode in the libxml XMLDocumentParser | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | XML | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 43085, 49581 | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2010-09-09 13:27:06 PDT
Created attachment 67087 [details]
Patch
Why? (In reply to comment #2) > Why? bug 43085 IMHO String::fromUTF8 avoids the TextEncoding overhead? I also want to replace most of the toString calls with a new toAtomicString method. QualifiedName (used for elements and attributes) takes AtomicString as arguments. Creating AtomicString instead of String can avoid many memcpy operations IMHO. If we implement a AtomicString::fromUTF8 which works directly with the utf8 data for hash and compare we can avoid many convertUTF8ToUTF16 operations too. (In reply to comment #3) > IMHO String::fromUTF8 avoids the TextEncoding overhead? OK. Next time you can just say so in the code or change log, and save a round of questioning ;-) Comment on attachment 67087 [details] Patch Clearing flags on attachment: 67087 Committed r67214: <http://trac.webkit.org/changeset/67214> All reviewed patches have been landed. Closing bug. Created attachment 74475 [details]
Patch #2
Missed the second toString in the first patch.
The commit-queue encountered the following flaky tests while processing attachment 74475 [details]: inspector/styles-source-offsets.html Please file bugs against the tests. These tests were authored by apavlov@chromium.org and pfeldman@chromium.org. The commit-queue is continuing to process your patch. Comment on attachment 74475 [details] Patch #2 Clearing flags on attachment: 74475 Committed r72476: <http://trac.webkit.org/changeset/72476> All reviewed patches have been landed. Closing bug. |