Bug 45464

Summary: Web Inspector: [REGRESSION] "Inspect Element" does not focus the pointed element in a newly opened Inspector
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested solution none

Alexander Pavlov (apavlov)
Reported 2010-09-09 09:29:44 PDT
1. Open any page 2. Right-click on any element, select "Inspect Element" 3. Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element 4. Inspect the Web Inspector. An error message is logged in the console. The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent instance (which makes focusNode() bail out prematurely).
Attachments
[PATCH] Suggested solution (1.57 KB, patch)
2010-09-09 09:46 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2010-09-09 09:46:33 PDT
Created attachment 67048 [details] [PATCH] Suggested solution
Ilya Tikhonovsky
Comment 2 2010-09-09 09:52:46 PDT
*** This bug has been marked as a duplicate of bug 45374 ***
Joseph Pecoraro
Comment 3 2010-09-09 09:53:24 PDT
r=me if you put the explanation you just put in comment #1 into the ChangeLog. That is what the ChangeLog is for! Note, you have the exact same patch as Ilya had on: <http://webkit.org/b/45374> Web Inspector: Selecting 'inspect element' always shows body in inspector instead of clicked element He put his patch up a little sooner though. I don't know if there is a policy or if it even matters. I was just looking for an explanation of this solution and you have a very good explanation here.
Note You need to log in before you can comment on or make changes to this bug.