Bug 45433

Summary: [EFL] Fix duplicate gstreamer macro in CMakeListEfl.txt
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, kenneth, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
tonikitoo: review+, tonikitoo: commit-queue-
Patch none

Gyuyoung Kim
Reported 2010-09-08 18:31:47 PDT
In WebKit/efl/CMakeListEfl.txt, duplicated ENABLE_VIDEO macros were added. So, I remove unnecessary thing. IF (ENABLE_VIDEO) LIST(APPEND WebKit_INCLUDE_DIRECTORIES "${WEBCORE_DIR}/platform/graphics/gstreamer" ${Gstreamer-App_INCLUDE_DIRS} ${Gstreamer-Interfaces_INCLUDE_DIRS} ${Gstreamer-Pbutils_INCLUDE_DIRS} ${Gstreamer-Video_INCLUDE_DIRS} ) ENDIF() IF (ENABLE_VIDEO) LIST(APPEND WebKit_INCLUDE_DIRECTORIES "${WEBCORE_DIR}/platform/graphics/gstreamer" ${GStreamer-App_INCLUDE_DIRS} ${GStreamer-Interfaces_INCLUDE_DIRS} ${GStreamer-Pbutils_INCLUDE_DIRS} ...
Attachments
Patch (1.32 KB, patch)
2010-09-08 18:35 PDT, Gyuyoung Kim 		tonikitoo: review+
tonikitoo: commit-queue-
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2010-09-08 19:08 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2010-09-08 18:35:28 PDT
Created attachment 66986 [details] Patch
Antonio Gomes
Comment 2 2010-09-08 18:55:29 PDT
Comment on attachment 66986 [details] Patch Fix the indentation in the changelog before landing.
Gyuyoung Kim
Comment 3 2010-09-08 19:08:05 PDT
Created attachment 66989 [details] Patch Oops, sorry. I fix it. :) Thanks.
WebKit Commit Bot
Comment 4 2010-09-09 02:06:38 PDT
Comment on attachment 66989 [details] Patch Clearing flags on attachment: 66989 Committed r67071: <http://trac.webkit.org/changeset/67071>
Gyuyoung Kim
Comment 5 2010-09-09 23:02:25 PDT
This bug's patch was landed to mainline. So, I change this bug's status with Resolved.
Note You need to log in before you can comment on or make changes to this bug.