Bug 45418

Summary:

Improve CoreIPC encoding of strings

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review+

Anders Carlsson

Reported 2010-09-08 15:58:45 PDT

Improve CoreIPC encoding of strings

Attachments
Patch (2.46 KB, patch) 2010-09-08 16:02 PDT, Anders Carlsson	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2010-09-08 16:02:28 PDT

Created attachment 66954 [details] Patch

Darin Adler

Comment 2 2010-09-08 16:17:10 PDT

Comment on attachment 66954 [details] Patch > + // Before allocating the string, make sure that the decoder buffer is big enough. > + if (!decoder->bufferIsLargeEnoughtToContain<UChar>(length)) { This function name has a typo: "Enought".

Anders Carlsson

Comment 3 2010-09-08 16:29:06 PDT

Committed r67034: <http://trac.webkit.org/changeset/67034>

WebKit Review Bot

Comment 4 2010-09-08 18:48:55 PDT

http://trac.webkit.org/changeset/67034 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/67033 http://trac.webkit.org/changeset/67034 http://trac.webkit.org/changeset/67035 http://trac.webkit.org/changeset/67036 http://trac.webkit.org/changeset/67037 http://trac.webkit.org/changeset/67038 http://trac.webkit.org/changeset/67039

Note You need to log in before you can comment on or make changes to this bug.