Bug 45401

Summary: Add Tracing to Regular Expression Code
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
RegExp Tracing Patch none

Michael Saboff
Reported 2010-09-08 11:12:55 PDT
Tracing of regular expressions including the original express, number of times used, number of times matched and optional JIT address would be helpful to debug and tune regular expression code.
Attachments
RegExp Tracing Patch (11.77 KB, patch)
2010-09-08 16:55 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2010-09-08 16:55:12 PDT
Created attachment 66965 [details] RegExp Tracing Patch
WebKit Commit Bot
Comment 2 2010-09-09 16:59:43 PDT
Comment on attachment 66965 [details] RegExp Tracing Patch Rejecting patch 66965 from commit-queue. msaboff@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 3 2010-09-09 17:42:10 PDT
Comment on attachment 66965 [details] RegExp Tracing Patch Rejecting patch 66965 from commit-queue. msaboff@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 4 2010-09-09 19:11:56 PDT
Comment on attachment 66965 [details] RegExp Tracing Patch Clearing flags on attachment: 66965 Committed r67146: <http://trac.webkit.org/changeset/67146>
WebKit Commit Bot
Comment 5 2010-09-09 19:12:00 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2010-09-10 09:40:00 PDT
+#if ENABLE(REGEXP_TRACING) + delete m_rtTraceList; +#endif Looks like m_rtTraceList could be an OwnPtr instead.
Note You need to log in before you can comment on or make changes to this bug.